Move RATE logging to attitude controller and log sample time #27996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyp1per
force-pushed
the
pr-rate-log
branch
3 times, most recently
from
70e5ed1
to
76669b4
Compare
andyp1per
changed the title
lthall
approved these changes
Sep 5, 2024
andyp1per
force-pushed
the
pr-rate-log
branch
from
76669b4
to
ed9f731
Compare
IamPete1
approved these changes
Sep 9, 2024
There was a problem hiding this comment.
I think this looks good. The only question is if any log tools have a problem with the log timestamp not matching the time the log was written. I don't think they should. Each message should still see a increasing time. Only between messages would time go backwards. The only other thing would be if we were to write the log twice in one loop for some reason then we would get two timestamps the same.
I guess we could get round this by adding a new timestamp rather than replacing the existing one, but that would make plotting in log review tools hard as there mostly hard coded to use TimeUS on the x axis.
rmackay9
reviewed
Sep 10, 2024
peterbarker
requested changes
Sep 10, 2024
move RATE log structure to AC_AttitudeControl
move Write_Rate() to AC_AttitudeControl move RATE log structure to AC_AttitudeControl
andyp1per
force-pushed
the
pr-rate-log
branch
from
ed9f731
to
5b85673
Compare
peterbarker
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With RATE logging it is crucial that both the last gyro value used and the time that it was used be recorded in the log rather than whatever happens to be available at the time the log is written. In addition it makes no sense for RATE logging to be in AHRS, it really has very little to do with AHRS and everything to do with the rate and attitude controllers. This PR moves the logging functionality and records the gyro value used and timestamp at the appropriate point for logging. This is especially important when the rate loop because faster and concurrent.
Split from #27029